Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Natspec indicating amount must be amount - 1 wei or less when claiming fees #73

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

alexkeating
Copy link
Collaborator

Description

  • Add natspec

Closes #65

@alexkeating alexkeating marked this pull request as ready for review March 20, 2024 12:28
src/V3FactoryOwner.sol Outdated Show resolved Hide resolved
src/V3FactoryOwner.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording nit but looks good

src/V3FactoryOwner.sol Outdated Show resolved Hide resolved
@wildmolasses wildmolasses self-requested a review March 25, 2024 13:59
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apbendi apbendi force-pushed the chore/add-max-amount-natspec branch from 54c4ce9 to bca9320 Compare March 26, 2024 14:35
@apbendi apbendi merged commit bdb850c into main Mar 26, 2024
4 checks passed
Copy link

Coverage after merging chore/add-max-amount-natspec into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol99.49%95.83%100%100%626
   V3FactoryOwner.sol100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update claimFees Natspec to Note that Max Amount requested must always leave 1 wei
3 participants